Skip to content

[stable2506] Backport #11703#11783

Merged
EgorPopelyaev merged 1 commit intostable2506from
backport-11703-to-stable2506
Apr 16, 2026
Merged

[stable2506] Backport #11703#11783
EgorPopelyaev merged 1 commit intostable2506from
backport-11703-to-stable2506

Conversation

@paritytech-release-backport-bot
Copy link
Copy Markdown

Backport #11703 into stable2506 from BDevParity.

See the documentation on how to use this bot.

## Summary

- The combined publish workflows (`release-70`, `release-22`) call
multiple sub-workflows that each invoke `check-synchronization.yml`.
That reusable workflow has a concurrency group (`${{ github.repository
}}-${{ github.workflow }}-${{ github.ref }}`) that evaluates to the
**same value** for all callers within a single run, causing GitHub to
randomly cancel competing jobs.
- PR #11631 attempted to fix this with `github.event_name ==
'workflow_dispatch'` guards, but `github.event_name` propagates the
original trigger through `workflow_call` chains, so the guard doesn't
reliably skip the check.
- This PR replaces that guard with an explicit `skip_sync_check` boolean
input. Combined workflows pass `skip_sync_check: true` since they
already run the check at the top level. Standalone dispatches default to
`false`, preserving existing behavior.
- Also removes the redundant `check-synchronization` job from
`release-reusable-publish-packages.yml` (only ever called from workflows
that already perform the check).

Evidence: [4 consecutive failed
attempts](https://github.com/paritytech-release/polkadot-sdk/actions/runs/23787944175)
with different random jobs cancelled each time.

## Issue

- paritytech/release-engineering#291

---------

Co-authored-by: Egor_P <egor@parity.io>
(cherry picked from commit 9f6182f)
@github-actions github-actions Bot added the A3-backport Pull request is already reviewed well in another branch. label Apr 15, 2026
@github-actions github-actions Bot requested a review from BDevParity April 15, 2026 19:15
@github-actions
Copy link
Copy Markdown
Contributor

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@EgorPopelyaev EgorPopelyaev added the R0-no-crate-publish-required The change does not require any crates to be re-published. label Apr 16, 2026
@EgorPopelyaev EgorPopelyaev enabled auto-merge (squash) April 16, 2026 08:16
@EgorPopelyaev EgorPopelyaev merged commit a428e1d into stable2506 Apr 16, 2026
319 of 322 checks passed
@EgorPopelyaev EgorPopelyaev deleted the backport-11703-to-stable2506 branch April 16, 2026 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A3-backport Pull request is already reviewed well in another branch. R0-no-crate-publish-required The change does not require any crates to be re-published.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants